Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOCS: describe shared axes behavior with units#18353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I attempted to create an example showing the behavior of
|
@jklymak Is this proposed PR sufficient? Creating an example using the existing basic_units definition isn't going to work as discussed above. I read the unitsdiscourse and see that units has a rather long history. Is there any work on defining an interface layer between incoming data and plot function internals? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems right? Are there other places wheresharex/y
are documented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@l-johnston This is good enough. We don't need an example.
Could you please also update the docstring ofGridSpecBase.subplots()
with the same paragraph.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Closes#18345
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
andpydocstyle<4
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).