Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Soft-deprecate Axes.plot_date()#18346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 3 commits intomatplotlib:masterfromtimhoffm:plot_date
May 8, 2021
Merged

Conversation

timhoffm
Copy link
Member

PR Summary

Closes#18154.

Copy link
Member

@story645story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Was there also gonna be aDeprecationWarning?

@timhoffm
Copy link
MemberAuthor

timhoffm commentedAug 24, 2020
edited
Loading

Yes, it's a little late here ...

I've made this a pending deprecation, which feels a bit better than a very long deprecation period.

--> Means we'll still have to deprecate explicitly in a later version.

@timhoffmtimhoffmforce-pushed theplot_date branch 2 times, most recently from2580646 tode6a915CompareAugust 25, 2020 21:00
tacaswell
tacaswell previously requested changesAug 28, 2020
Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 in principle, but I think that this need a note in the API changes page.

Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Woops, I approved before seeing the CI, that should probably be fixed! 👍 in theory though

@timhoffmtimhoffmforce-pushed theplot_date branch 2 times, most recently from4545764 tobcae8a7CompareApril 26, 2021 20:29
@timhoffm
Copy link
MemberAuthor

PendingDeprecationWarning was not playing nicely with sphinx (warnings causing sphinx to fail). I suppose we'd have to include special handing for that.

Instead of aPendingDeprecationWarning I went back to only discouraging this code. In both cases we'd have to add aDeprecationWarning to later releases if we want to finally remove it. So there's no real benefit of the pending deprecation warning.

@timhoffm
Copy link
MemberAuthor

Macos test failure seems unrelated (subprocess timed out).

@jklymakjklymak requested a review fromdstansbyMay 8, 2021 20:45
@jklymak
Copy link
Member

@dstansby I think that CI is happier now...

@jklymakjklymak merged commitee6a42f intomatplotlib:masterMay 8, 2021
@QuLogicQuLogic added this to thev3.5.0 milestoneMay 10, 2021
@timhoffmtimhoffm deleted the plot_date branchJune 10, 2022 21:19
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak left review comments

@story645story645story645 approved these changes

@dstansbydstansbydstansby approved these changes

@tacaswelltacaswelltacaswell left review comments

Assignees
No one assigned
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

Deprecate plot_date()
6 participants
@timhoffm@jklymak@tacaswell@story645@dstansby@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp