Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Soft-deprecate Axes.plot_date()#18346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Was there also gonna be aDeprecationWarning
?
timhoffm commentedAug 24, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, it's a little late here ... I've made this a pending deprecation, which feels a bit better than a very long deprecation period. --> Means we'll still have to deprecate explicitly in a later version. |
Uh oh!
There was an error while loading.Please reload this page.
2580646
tode6a915
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 in principle, but I think that this need a note in the API changes page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Woops, I approved before seeing the CI, that should probably be fixed! 👍 in theory though
4545764
tobcae8a7
Compare
Instead of a |
Macos test failure seems unrelated (subprocess timed out). |
@dstansby I think that CI is happier now... |
PR Summary
Closes#18154.