Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add on_toggle method instead of enable/disable in ToolToggleBase#18332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Ptrskay3 wants to merge2 commits intomatplotlib:main
base:main
Choose a base branch
Loading
fromPtrskay3:tooltogglebase-api-change

Conversation

Ptrskay3
Copy link
Contributor

Related to#18331 .

PR Summary

Changedtrigger inToolToggleBase to callon_toggle(state, event) whenever the state ofself._toggled changes. Also it is backward compatible withenable(event) anddisable(event). Additionally I changedToolFullScreen,AxisScaleBase andZoomPanBase to use the newon_toggle method.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@Ptrskay3Ptrskay3 marked this pull request as draftAugust 25, 2020 10:12
@anntzer
Copy link
Contributor

Thanks for the PR. I'll leave it to others to decide whether we do want the API change first, or at least comment on it, before looking at the actual implementation.

@github-actions
Copy link

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actionsgithub-actionsbot added the status: inactiveMarked by the “Stale” Github Action labelAug 18, 2023
@anntzer
Copy link
Contributor

I'll rebase and finish fixing that PR, but that'll go on top of#26580 as it turns out some tools shouldn't be toggles after all.

@github-actionsgithub-actionsbot removed the status: inactiveMarked by the “Stale” Github Action labelAug 25, 2023
@github-actions
Copy link

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actionsgithub-actionsbot added the status: inactiveMarked by the “Stale” Github Action labelOct 25, 2023
@anntzer
Copy link
Contributor

Still blocked by#26580, but the idea is correct I think.

@anntzeranntzer added keepItems to be ignored by the “Stale” Github Action and removed status: inactiveMarked by the “Stale” Github Action labelsOct 25, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API: changeskeepItems to be ignored by the “Stale” Github ActionMEP: MEP22tool managerstatus: needs rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Ptrskay3@anntzer
[8]ページ先頭
©2009-2025 Movatter.jp