Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix scatter3d color/linewidth re-projection#18293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dopplershift merged 5 commits intomatplotlib:masterfromQuLogic:scatter3d-color
Aug 29, 2020

Conversation

QuLogic
Copy link
Member

PR Summary

Technically, it's tested, though the test wasn't strictly designed to do so (#18156). Not sure if I should write a different test.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • [n/a] New features are documented, with examples if plot related
  • [n/a] Documentation is sphinx and numpydoc compliant
  • [n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [n/a] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

They should be re-ordered regardless of depth shading, but ratherdependent on whether there's more than one colour.Fixesmatplotlib#18287.
@QuLogicQuLogic added this to thev3.3.2 milestoneAug 19, 2020
@timhoffm
Copy link
Member

Technically, it's tested, though the test wasn't strictly designed to do so (#18156). Not sure if I should write a different test.

How can this have been tested? The behavior was broken and is now fixed, but you did not have to change anything in the tests.

@dopplershift
Copy link
Contributor

That lines up with where codecov says exactly 0% of the lines of code touched in this PR have been executed by the test suite.

@QuLogic
Copy link
MemberAuthor

Sorry, I guess what is tested is theopposite case. I can write up something that should cover everything.

@QuLogicQuLogic changed the titleFix scatter3d color re-projectionFix scatter3d color/linewidth re-projectionAug 19, 2020
@QuLogic
Copy link
MemberAuthor

I pushed a more extensive test, and also found that linewidth was not correctly propagated, so fixed that as well.

There's still a bug in#18287 in that initial draw is not correct, but any change in the view angle re-calculates stuff so it appears correctly. I think there's some stale trigger missing inview_init, but need to investigate that for a bit.

@QuLogic
Copy link
MemberAuthor

I'm very confused about this initial draw thing. To be clear, this PR does fix the sorting, which you can confirm by running#18287, and then rotating the view of the first figure so that the markers's depths are reversed.

However, on the second figure, the face colours of the scatter markers are not sorted, though the edge colours are. Inserting adraw (of any kind, lazy or forced) just beforeplt.show() magically fixes it. As far as I can tell,Path3DCollection.do_3d_projection sorts everything exactly the same way on both draws, but somehow it doesn't reflect that in the result.

@tacaswell
Copy link
Member

I'm happy to merge this as-is without tracking down why the initial draw is wrong (which is not to say that isn't a bug that needs to be fixed).

Copy link
Contributor

@dopplershiftdopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree, let's deal with any initial draw issues in a separate PR.

@dopplershiftdopplershift merged commit52f7f42 intomatplotlib:masterAug 29, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 29, 2020
timhoffm added a commit that referenced this pull requestAug 29, 2020
…293-on-v3.3.xBackport PR#18293 on branch v3.3.x (Fix scatter3d color/linewidth re-projection)
@QuLogicQuLogic deleted the scatter3d-color branchAugust 30, 2020 01:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@dopplershiftdopplershiftdopplershift approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.

4 participants
@QuLogic@timhoffm@dopplershift@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp