Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: check if axes is off page before repositioning title#18288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 3 commits intomatplotlib:masterfromjklymak:fix-check-title-off-page
Aug 19, 2020

Conversation

jklymak
Copy link
Member

@jklymakjklymak commentedAug 18, 2020•
edited
Loading

PR Summary

Closes#18283

We now automatically place the title to avoid decorators on the x axis (particuarly if the axis is at the top). However if the whole axes is cropped due to abbox_inches=extent call, then the title still gets placed at a defaulty=0. This change checks if thetop is in the figure, and if not, then it doesn't auto position the title.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@jklymakjklymak added the topic: geometry managerLayoutEngine, Constrained layout, Tight layout labelAug 18, 2020
@jklymakjklymak added this to thev3.3.2 milestoneAug 18, 2020
@jklymak
Copy link
MemberAuthor

yeeesh, why am I getting flake8 complaints for a file I didn't edit?

@tacaswell
Copy link
Member

It looks like something changed in the flake8 incantation?

@@ -1,6 +1,5 @@
from io import BytesIO
import pickle
import platform
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is just to make flake8 happy - not part of this PR, but flake8 now seems to check all files, not just modified.

@jklymakjklymakforce-pushed thefix-check-title-off-page branch from9e8acd6 toa9ac3d9CompareAugust 18, 2020 21:48
@timhoffmtimhoffm merged commitce6ac2d intomatplotlib:masterAug 19, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 19, 2020
timhoffm added a commit that referenced this pull requestAug 19, 2020
…288-on-v3.3.xBackport PR#18288 on branch v3.3.x (FIX: check if axes is off page before repositioning title)
SidharthBansal pushed a commit to SidharthBansal/matplotlib that referenced this pull requestAug 20, 2020
…pageFIX: check if axes is off page before repositioning title
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dopplershiftdopplershiftdopplershift approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
topic: geometry managerLayoutEngine, Constrained layout, Tight layout
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.

Automatic title placement wrong if parent axes is off the page
4 participants
@jklymak@tacaswell@dopplershift@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp