Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

MNT: do a better job guessing the GUI framework in use#18245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jkseppan merged 1 commit intomatplotlib:masterfromtacaswell:lazier_headless
Aug 14, 2020

Conversation

tacaswell
Copy link
Member

PR Summary

We currently check the GUI framework and reject changing to
a different framework. This adds the ability to check the running
framework before we start guessing frameworks to use.

This matters the most in the headless linux case where you have a lot of the GUI frameworks available. Currently we try to importall of them before we give up (despite the fact that it is check on our side that is failing them!)

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant

@tacaswelltacaswell added this to thev3.3.2 milestoneAug 13, 2020
We currently check the GUI framework and reject changing toa different framework.  This adds the ability to check the runningframework before we start guessing frameworks to use.
@jkseppanjkseppan merged commit6a40954 intomatplotlib:masterAug 14, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.3.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 6a40954aefc760861c85c5a94cb7270903e603ea
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #18245: MNT: do a better job guessing the GUI framework in use'
  1. Push to a named branch :
git push YOURFORK v3.3.x:auto-backport-of-pr-18245-on-v3.3.x
  1. Create a PR against branch v3.3.x, I would have named this PR:

"Backport PR#18245 on branch v3.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

jkseppan added a commit to jkseppan/matplotlib that referenced this pull requestAug 14, 2020
@tacaswelltacaswell deleted the lazier_headless branchAugust 14, 2020 12:35
dopplershift added a commit that referenced this pull requestAug 14, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jkseppanjkseppanjkseppan approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.

3 participants
@tacaswell@jkseppan@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp