Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: check we have a back button in tk toolbar before we touch it#18235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromtacaswell:tk_no_back_button
Aug 13, 2020

Conversation

tacaswell
Copy link
Member

PR Summary

We add one by default, but sub-classes may remove it.

closes#18232

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant

We add one by default, but sub-classes may remove it.closesmatplotlib#18232
@tacaswelltacaswell added this to thev3.3.1 milestoneAug 12, 2020
@QuLogicQuLogic merged commit0375315 intomatplotlib:masterAug 13, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.3.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 03753154ef2d555bc2badfc75defa62b653fe30c
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #18235: FIX: check we have a back button in tk toolbar before we touch it'
  1. Push to a named branch :
git push YOURFORK v3.3.x:auto-backport-of-pr-18235-on-v3.3.x
  1. Create a PR against branch v3.3.x, I would have named this PR:

"Backport PR#18235 on branch v3.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestAug 13, 2020
tacaswell added a commit that referenced this pull requestAug 13, 2020
@QuLogicQuLogic mentioned this pull requestAug 13, 2020
@tacaswelltacaswell deleted the tk_no_back_button branchMay 6, 2021 23:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.

different behaviour between 3.3.0 and 3.2.2 (and earlier) for plotting in a Tk canvas
3 participants
@tacaswell@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp