Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Force locator and formatter inheritance#18203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromdstansby:tick-form-depr
Aug 18, 2020

Conversation

dstansby
Copy link
Member

Deprecated in 3.2, locators and formatters are now forced to be sub-classes of their respective base class.

@dstansbydstansby added this to thev3.4.0 milestoneAug 8, 2020
tacaswell
tacaswell previously requested changesAug 12, 2020
Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree with@timhoffm that these should be TypeError

Passing arguments of the wrong type (e.g. passing a list when an int is expected) should result in a TypeError, but passing arguments with the wrong value (e.g. a number outside expected boundaries) should result in a ValueError.

@QuLogicQuLogic dismissedtacaswell’sstale reviewAugust 18, 2020 04:57

Exception class changed.

@timhoffmtimhoffm merged commit035bf30 intomatplotlib:masterAug 18, 2020
@dstansbydstansby deleted the tick-form-depr branchAugust 18, 2020 10:32
@QuLogicQuLogic changed the titleForce locator and formatter inheritenceForce locator and formatter inheritanceJun 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

@tacaswelltacaswelltacaswell left review comments

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

4 participants
@dstansby@tacaswell@QuLogic@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp