Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: Add get/set methods for 3D collections#18189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
4 tasks
5918750 to68cec33Compare This was linked to issuesSep 17, 2020
closesmatplotlib#3370We need to do an extra step to propagate the color information back tothe 3D projections
This now has tests, a what's new entry, and should have get/set for all the properties overridden in 3D collections. |
5 tasks
dopplershift approved these changesSep 22, 2020
I can't approve because I opened the PR from my fork, but plan to merge when it goes green. Thank you for cleaning up work I started@QuLogic :) |
This was referencedMar 24, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
closes#3370
We need to do an extra step to propagate the color information back to
the 3D projections
PR Summary
Replaces#5598, still needs tests.
PR Checklist