NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

TST: exercise pyinstaller in tests#18188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

tacaswell wants to merge1 commit intomatplotlib:main

base:main

Choose a base branch

fromtacaswell:tst_pyinstaller

Draft

TST: exercise pyinstaller in tests#18188

tacaswell wants to merge1 commit intomatplotlib:mainfromtacaswell:tst_pyinstaller

Conversation

Copy link

Member

tacaswell commentedAug 6, 2020

PR Summary

I am going to say thiscloses#3391 even though the original issue was targetting cx_freeze rather than pyinstaller.

This is waiting onpyinstaller/pyinstaller#5004 to be fixed and release on the pyinstaller side.

A concern that@efiring brought up when this issue was initially created is that how should we deal with it when it fails. I think the procedure should be to reach out to the pyinstaller folks and sort out if we should temporarily disable the test on our side or find some other way to do what we want to do.

PR Checklist

Has Pytest style unit tests

TST: exercise pyinstaller in tests

dd13a2c

tacaswell added this to thev3.4.0 milestone

Aug 6, 2020

jkseppan added the status: upstream fix required label

Aug 8, 2020

QuLogic modified the milestones:v3.4.0,v3.5.0

Jan 22, 2021

tacaswell modified the milestones:v3.5.0,v3.6.0

Aug 5, 2021

QuLogic modified the milestones:v3.6.0,v3.7.0

Jul 5, 2022

github-actionsbot added the status: needs rebase label

Oct 18, 2022

tacaswell modified the milestones:v3.7.0,future releases

Dec 9, 2022

Copy link

Member

QuLogic commentedMay 4, 2023

It looks like the upstream issue has been closed, but now Travis is gone...

Copy link

github-actionsbot commentedAug 14, 2023

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.