Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

allow webAgg to report middle click events#18172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 3 commits intomatplotlib:masterfromianhi:report-button-correctly
Aug 5, 2020

Conversation

ianhi
Copy link
Contributor

I removed the code in webAgg_core that prevented a user from being able to differentiate between middle click and right click events with amouse_button_event callback. I removed this forcing of the reported button from 2->3. This code was originally added to account for difficulties in preventing the context menu in chrome 23#1426 (comment) which in modern chrome should be possible. There was a comment asking to remove mention of this from the MouseEvent docstring, however the current docstring does not seem to mention this so I did not change anything there.

Closes:matplotlib/ipympl#254
Closes:#18171

PR Summary

PR Checklist

  • Has Pytest style unit tests (does remove code require writing a new test?)
  • Code isFlake 8 compliant
  • na New features are documented, with examples if plot related
  • na Documentation is sphinx and numpydoc compliant
  • na Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • na? Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

The current MouseEvent docstring has no mention of this issue so I did not remove anything there. This code was originally added to account for difficulties in preventing the context menu in chrome 23matplotlib#1426 (comment)
@QuLogic
Copy link
Member

The right-click menu should be fixed by#18142, so yes, that comment is outdated.

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe this should get a behavioural change API note?

@ianhi
Copy link
ContributorAuthor

I added a note.

The right-click menu should be fixed by#18142,

Only 4 days ago! I guess I got lucky with my timing

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@timhoffm
Copy link
Member

Anybody can merge after CI pass.

@timhoffmtimhoffm added this to thev3.4.0 milestoneAug 5, 2020
@QuLogicQuLogic merged commitdffc19c intomatplotlib:masterAug 5, 2020
@QuLogic
Copy link
Member

Thanks@ianhi! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

ianhi reacted with rocket emoji

@ianhiianhi deleted the report-button-correctly branchAugust 5, 2020 15:23
QuLogic added a commit to QuLogic/matplotlib that referenced this pull requestSep 10, 2020
@QuLogicQuLogic mentioned this pull requestSep 10, 2020
2 tasks
danuo pushed a commit to danuo/matplotlib that referenced this pull requestSep 11, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

webAgg backend incorrectly reports middle clicks as right clicks Middle click event is reported as right click
3 participants
@ianhi@QuLogic@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp