Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix nbagg in Chrome 84#18142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Fix nbagg in Chrome 84#18142
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The ResizeObserver spec changed, though Firefox still does the old way.Previous Chrome implemented an even older version, and 84 implements thelatest version, but not this in-between one we're using.
This is only implemented on Chrome, but prevents some blurriness.
jkseppan approved these changesAug 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me, although I don't know the details of all the specs. I trust that you tested this with the browsers mentioned in comments.
jklymak approved these changesAug 2, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 2, 2020
dopplershift added a commit that referenced this pull requestAug 2, 2020
…142-on-v3.3.xBackport PR#18142 on branch v3.3.x (Fix nbagg in Chrome 84)
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
GUI: nbaggGUI: webaggRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
We check attributes for Firefox, and old Chrome. Chrome 84 implements a new version of the
ResizeObserverspec, which uses the same attribute names as Firefox, but a different type. Naturally, JS doesn't complain and just returns undefined...Also, fix the menu showing up on right-click.
Fixes#18132.
PR Checklist