Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use QuickLook instead of gs and inkscape on MacOS#18140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
jkseppan wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromjkseppan:quicklook-convert

Conversation

jkseppan
Copy link
Member

qlmanage is built into MacOS since 10.5 and is faster to call than
either of the alternatives

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@jkseppan
Copy link
MemberAuthor

I had some failing tests locally, but let's see how it works in Travis

@tacaswell
Copy link
Member

We might need to clear the cache of converted to png expected files?

@tacaswelltacaswell added this to thev3.4.0 milestoneJul 31, 2020
@jkseppan
Copy link
MemberAuthor

We might need to clear the cache of converted to png expected files?

The cache keys are hashes that include the software version number. There are no version numbers for qlmanage, so I just used "qlmanage". This way the cached files from gs/inkscape shouldn't affect the tests.

@QuLogic
Copy link
Member

There are no version numbers for qlmanage

Would it make sense to insert the macOS version there, then? I don't expect a lot of people to have cache files from full system upgrades lying around, but maybe some kind of shared directory between VMs, or something.

@jkseppan
Copy link
MemberAuthor

There are no version numbers for qlmanage

Would it make sense to insert the macOS version there, then? I don't expect a lot of people to have cache files from full system upgrades lying around, but maybe some kind of shared directory between VMs, or something.

That makes sense, and AFAIK even full system upgrades leave your home directory alone so the cached files could still be there.

@jkseppan
Copy link
MemberAuthor

The tests are now stopped by Travis timing out. The test run was not fast before, and skipping pdf and svg tests may have kept it under the Travis limit.

#18134 installs dependencies without homebrew, and as a side effect makes the installation quite a bit faster. If that gets merged, let's try this again.

qlmanage is built into MacOS since 10.5 and is faster to call thaneither of the alternatives
@jkseppan
Copy link
MemberAuthor

Now we no longer time out, but there are plenty of image-comparison errors, most with small differences but in one test "RMS 19.782".

@QuLogic
Copy link
Member

That's a hatching one, which we often have trouble with depending on viewer, like#8289. I don't see any more current issues, though.

@jklymakjklymak marked this pull request as draftSeptember 23, 2020 20:15
@jklymak
Copy link
Member

This isn't passing, so I've marked as draft...

@QuLogicQuLogic modified the milestones:v3.4.0,v3.5.0Jan 22, 2021
@QuLogicQuLogic modified the milestones:v3.5.0,v3.6.0Aug 23, 2021
@timhoffmtimhoffm modified the milestones:v3.6.0,unassignedApr 30, 2022
@story645story645 modified the milestones:unassigned,needs sortingOct 6, 2022
@github-actions
Copy link

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actionsgithub-actionsbot added the status: inactiveMarked by the “Stale” Github Action labelAug 14, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
future releases
Development

Successfully merging this pull request may close these issues.

6 participants
@jkseppan@tacaswell@QuLogic@jklymak@story645@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp