Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Build on xcode9#18134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Build on xcode9#18134
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The CI run fails when installing sqlite from Homebrew. Homebrew prints out a warning that macOS 10.12 is unsupported by them and that pull requests are welcome but requests for help are not. |
Homebrew doesn't support 10.12 any more, so build the dependencieswithout homebrew.
Qt5 supports MacOS 10.13 and up, and XCode 11:https://doc.qt.io/qt-5/macos.html |
ffddd20 to7ab5236Comparedoes it actually do anything?
We have deprecated qt4 support so I don''t think it is worth writing tests. If we get the pyqt5 coverage on azure that seems OK. |
| set -euo pipefail | ||
| fold_start() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🤯
In that case we can speed up the build a little by not installing qt4. |
ci/osx-deps Outdated
| fold_end libpng | ||
| fold_start freetype 'Install freetype (just unpack into the build directory)' | ||
| curl -O -L https://download.savannah.gnu.org/releases/freetype/freetype-2.6.1.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why can't we just rely on what's already going on insetupext.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm sure I added this because of some reason, but the details are lost in the rebases... I'll see if and how the build fails without this step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thebuild ends with the error message
error: Failed to download FreeType. Please download one of ['https://downloads.sourceforge.net/project/freetype/freetype2/2.6.1/freetype-2.6.1.tar.gz', 'https://download.savannah.gnu.org/releases/freetype/freetype-2.6.1.tar.gz'] and extract it into build/freetype-2.6.1 at the top-level of the source repository.
I don't know how it is trying to download the file, but perhaps the older MacOS version doesn't support it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's just using standard libraryurllib. Two possibilities, the SSL certificates are old/not found, or the cache location is not writable.
Uh oh!
There was an error while loading.Please reload this page.
and put that directory in the Travis cache, for perhaps an additionalspeedup and to reduce the traffic we cause to the download sites
and use two processes for ccache compilation
$HOME/Downloads did not get cached, .cache/matplotlib already is
The build is now also faster than any of the Linux builds (but much of that is because we don't run svg or pdf tests on Mac). |
@meeseeksdev backport to v3.3.x |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
This sets up Travis so that the Mac tests use XCode 9 on MacOS 10.12.
Homebrew doesn't support this configuration, so we install the library dependencies without it. Tests requiring Qt5 are skipped becauseQt5 requires 10.13 or later. We do install Qt4 and at least PySide seems to work, so it is possible to write tests for Qt4.
PR Checklist