Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Support data reference for hexbin() parameter C#18103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Easy! But hard to tell if it worked - is it OK just to assume the preprocessor works because it works on other functions? |
I'll answer that with a yes. The preprocessor itself is tested. We don't want to test every variant of possible calls to the plotting functions. |
Sure, just wanted to make sure it was tested somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
Failing tests are:
They're unrelated and passing here for me on OSX on Python 3.8...so do we ignore or re-run? |
Those also failed on#18100. So I don't think it is these PRs, though its possible it is a previous PR that has worked its way into master... |
PR Summary
Closes#18097.