Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support data reference for hexbin() parameter C#18103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:masterfromtimhoffm:hexbin-data
Jul 29, 2020

Conversation

timhoffm
Copy link
Member

PR Summary

Closes#18097.

@jklymak
Copy link
Member

Easy! But hard to tell if it worked - is it OK just to assume the preprocessor works because it works on other functions?

@timhoffm
Copy link
MemberAuthor

I'll answer that with a yes. The preprocessor itself is tested. We don't want to test every variant of possible calls to the plotting functions.

jklymak reacted with thumbs up emoji

@jklymak
Copy link
Member

Sure, just wanted to make sure it was tested somewhere.

Copy link
Contributor

@dopplershiftdopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@dopplershift
Copy link
Contributor

Failing tests are:

lib/matplotlib/tests/test_animation.py::test_draw_framelib/matplotlib/tests/test_arrow_patches.py::test_fancyarrow[pdf]

They're unrelated and passing here for me on OSX on Python 3.8...so do we ignore or re-run?

@jklymak
Copy link
Member

Those also failed on#18100. So I don't think it is these PRs, though its possible it is a previous PR that has worked its way into master...

@jklymakjklymak merged commit97e525c intomatplotlib:masterJul 29, 2020
@timhoffmtimhoffm deleted the hexbin-data branchJuly 29, 2020 08:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@dopplershiftdopplershiftdopplershift approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow hexbin to use a string for parameter C to refer to column in data (DataFrame)
3 participants
@timhoffm@jklymak@dopplershift

[8]ページ先頭

©2009-2025 Movatter.jp