NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Fix linting on v3.3.x#18102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jkseppan merged 3 commits intomatplotlib:v3.3.xfromQuLogic:flake8-v33x

Jul 30, 2020

Merged

Fix linting on v3.3.x#18102

jkseppan merged 3 commits intomatplotlib:v3.3.xfromQuLogic:flake8-v33x

Jul 30, 2020

Conversation

Copy link

Member

QuLogic commentedJul 28, 2020

PR Summary

Backport of#18091, plus correction of flake8 error (see commits).

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
[n/a] New features are documented, with examples if plot related
[n/a] Documentation is sphinx and numpydoc compliant
[n/a] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
[n/a] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

QuLogic added2 commits

July 28, 2020 17:46

ci: Add tee to debug reviewdog.

575c37b

ci: Disable filtering of lint errors.

5cfec07

For certain reporters, it's necessary to do this filtering becauseGitHub does not allow posting to unrelated files. The github-checkreporter _should_ allow it though, and we want to catch things likeunused imports that may not be in the diff.

QuLogic added the Maintenance label

Jul 28, 2020

QuLogic added this to thev3.3.1 milestone

Jul 28, 2020

Silence an unused import warning.

89d05ca

Since this is on a bugfix branch, don't remove the import in case it'sin use.And fix a missing empty line.

QuLogic force-pushed theflake8-v33x branch from5c96138 to89d05caCompare

July 28, 2020 22:03

timhoffm reviewed

Jul 28, 2020

View reviewed changes

lib/matplotlib/figure.pyShow resolvedHide resolved

timhoffm approved these changes

Jul 29, 2020

View reviewed changes

Copy link

Member

timhoffm commentedJul 29, 2020

CI failure Will be fixed by#18104.

jkseppan approved these changes

Jul 30, 2020

View reviewed changes

Copy link

Member

jkseppan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code looks good to me but there are some Travis failures. I restarted the failing jobs, but I don't know if Travis will merge the current v3.3.x before running the tests. If not, perhaps this branch could be rebased on top of v3.3.x.