Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Support scale in ttf composite glyphs#18081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
e1d4421
to8293741
CompareI'll trust you on the ttf parsing, but otherwise the patch looks reasonable. |
Oops, made a typo with a push and accidentally closed this. |
If someone wants to check the code against documentation, composite glyphs are described athttps://docs.microsoft.com/en-us/typography/opentype/spec/glyf#composite-glyph-description and 2.14 fixed-point format athttps://docs.microsoft.com/en-us/typography/opentype/otspec181/otff#data-types (search for F2DOT14). |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
If I run outside the test framework, it appears to be okay? |
Yes, I couldn't reproduce this. It might have been some problem with an intermediate version, as I might have forgotten to compile the extension when running some test. |
QuLogic commentedAug 1, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
To clarify, Ican reproduce if running in the test suite, by removing the explicit extension from the comparison settings. This is because tests disable hinting with |
The test failures are because of unrelated Pandas deprecations; apparently Pandas 1.1.0 is now available |
This is already fixed on master; you should rebase if you're having trouble with it. |
The GNU Free Serif font has a wide variety of characters with whichwe can exercise the linear transforms used in TTF composite glyphs.
These could increase the file length in case of fonts withmany composite glyphs.
It looks like you may have accidentally reverted some things in that last rebase? |
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
You're right, it looks like I lost the suggestions committed via the Github web UI. I committed those again. |
See#18181 for an alternate solution, though (which can reasonably avoid adding a new font file in the repo, and in any case seems more robust in the long term, as it can Type3-subset any font that FreeType can outline-decompose). |
Still approving, but perhaps make a decision wrt#18181 first.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#17197
I added a test using Free Serif, which has plenty of composite characters such as arrows drawn by rotating other arrows.
PR Summary
PR Checklist