Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Correctly handle 'none' facecolors in do_3d_projection#18060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
dstansby wants to merge1 commit intomatplotlib:masterfromdstansby:rgba-fix

Conversation

dstansby
Copy link
Member

Fixes#18020.

Changes made in#17543 meant that_facecolor3d can now be an empty array, therefore make suredo_3d_projection only handles the case where the facecolor is set.

@dstansbydstansby changed the titleOnly handle len > 0 facecolors in do_3d_projectionCorrectly handle 'none' facecolors in do_3d_projectionJul 25, 2020
@dstansbydstansby added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelJul 25, 2020
@dstansbydstansby added this to thev3.3.1 milestoneJul 25, 2020
@tacaswell
Copy link
Member

We might not have to backport this given that#17861 reverted the changes on v3.3.x?

@tacaswell
Copy link
Member

#17850 is also relevant here?

@dstansbydstansby modified the milestones:v3.3.1,v3.4.0Jul 30, 2020
@dstansbydstansby removed the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelJul 30, 2020
@dstansby
Copy link
MemberAuthor

@QuLogic
Copy link
Member

#17850 was merged, so it looks like this needs to be changed to only include the test.

@dstansby
Copy link
MemberAuthor

Looks like#18020 is closed, so I'm going to close this too.

@QuLogic
Copy link
Member

Did you not want to keep the test?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.2
Development

Successfully merging this pull request may close these issues.

Scatter3D: facecolor or color to "none" leads to an error
5 participants
@dstansby@tacaswell@QuLogic@timhoffm@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp