Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FIX: update num2julian and julian2num#18021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromjklymak:fix-update-num2julian
Jul 24, 2020

Conversation

jklymak
Copy link
Member

PR Summary

I guess ifepoch2num should be follow matplotlib epoch, thenjulian2num should as well...

Follow up to#17983

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@jklymakjklymak added this to thev3.3.1 milestoneJul 22, 2020
@jklymakjklymakforce-pushed thefix-update-num2julian branch 6 times, most recently from9611ec8 tocec46b5CompareJuly 22, 2020 23:19
@jklymak
Copy link
MemberAuthor

Here is the render of the deprecation notice:https://41969-1385122-gh.circle-artifacts.com/0/doc/build/html/api/next_api_changes/deprecations/17983-JMK.html#functions-epoch2num-and-julian2num-use-rcparams-date-epoch-default-1970-01-01t00-00-00

Note thatjulian2num doesn't actually appear in our docs, but its indates.py.

@jklymakjklymakforce-pushed thefix-update-num2julian branch 3 times, most recently fromaa871f8 to97d1685CompareJuly 23, 2020 21:16
Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mostly minor stuff.

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Conditional on doc build fix.

Apply suggestions from code reviewCo-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@jklymakjklymakforce-pushed thefix-update-num2julian branch from9c20006 to4757d98CompareJuly 24, 2020 14:20
@QuLogicQuLogic merged commit4b179b9 intomatplotlib:masterJul 24, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.3.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 4b179b92c0fa100a2ebea3a80aadf4fc59b8d14d
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #18021: FIX: update num2julian and julian2num'
  1. Push to a named branch :
git push YOURFORK v3.3.x:auto-backport-of-pr-18021-on-v3.3.x
  1. Create a PR against branch v3.3.x, I would have named this PR:

"Backport PR#18021 on branch v3.3.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

jklymak pushed a commit to jklymak/matplotlib that referenced this pull requestJul 24, 2020
@jklymakjklymak deleted the fix-update-num2julian branchJuly 24, 2020 21:34
QuLogic added a commit that referenced this pull requestJul 24, 2020
…3.3.xBackport PR#18021: FIX: update num2julian and julian2num
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.

3 participants
@jklymak@QuLogic@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp