Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Special case degree-1 Bezier curves.#17994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This greatly speeds up extent computation for the common case ofpolylines. (We were previously only special-casing the degree-0 case.)
6 tasks
jklymak approved these changesJul 21, 2020
dopplershift approved these changesJul 21, 2020
@meeseeksdev backport to v3.3.x |
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 5, 2020
QuLogic added a commit that referenced this pull requestAug 5, 2020
…994-on-v3.3.xBackport PR#17994 on branch v3.3.x (Special case degree-1 Bezier curves.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This greatly speeds up extent computation for the common case of
polylines. (We were previously only special-casing the degree-0 case.)
Partiallyfixes#17974 (4x speedup locally). My guess is that the real fix will involve restoring a special-case in Path.get_extents for paths that do not contain curves, but this fix is still useful by itself with no additional complexity cost.
PR Summary
PR Checklist