NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Make inset_axes and secondary_axis picklable.#17993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tacaswell merged 1 commit intomatplotlib:masterfromanntzer:pis

Jul 21, 2020

Merged

Make inset_axes and secondary_axis picklable.#17993

tacaswell merged 1 commit intomatplotlib:masterfromanntzer:pis

Jul 21, 2020

Conversation

Copy link

Contributor

anntzer commentedJul 21, 2020

... by making the locator a class, instead of a nested function.
Also, reuse the inset_locator machinery in secondary_axis, instead of
duplicating it there.

Supersedes#17249, which only unduplicated secondary/inset (or I can rebase on top of it after it gets merged).

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

Make inset_axes and secondary_axis picklable.

623ed98

... by making the locator a class, instead of a nested function.Also, reuse the inset_locator machinery in secondary_axis, instead ofduplicating it there.