Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Deprecate hatch patterns with invalid values#17926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 2 commits intomatplotlib:masterfromQuLogic:warn-hatch
Jul 17, 2020

Conversation

QuLogic
Copy link
Member

PR Summary

I noticed while going over the hatch doc PRs that we don't really validate this. This magically works because we just check for the count of the various hatch characters. Since it used to 'work', this adds a deprecation period over which people can fix their calls.

Also, use the new hatch style reference in theCollection docstring since that's more in line with what the docstring is asking for.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@QuLogicQuLogicforce-pushed thewarn-hatch branch 2 times, most recently from9e10c6e to9bbc045CompareJuly 15, 2020 05:49
Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks 👍 overall.backend_bases.GraphicsContextBase also has aset_hatch, does the same validation need applying there?

Instead of the hatch demo, which doesn't do what the docstring says itdoes.
@QuLogic
Copy link
MemberAuthor

I didn't expect a user to be callingbackend_bases.GraphicsContextBase.set_hatch directly, so that's why I didn't add anything to it.

dstansby reacted with thumbs up emoji

@dstansbydstansby merged commite5454a3 intomatplotlib:masterJul 17, 2020
@QuLogicQuLogic deleted the warn-hatch branchJuly 17, 2020 09:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@timhoffm@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp