NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Rewrite the barcode example#17922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

QuLogic merged 1 commit intomatplotlib:masterfromtimhoffm:doc-barcode

Jul 17, 2020

Merged

Rewrite the barcode example#17922

QuLogic merged 1 commit intomatplotlib:masterfromtimhoffm:doc-barcode

Jul 17, 2020

Conversation

Copy link

Member

timhoffm commentedJul 14, 2020

PR Summary

This example is a bit particular anyway, but let's make it practical by
generating a real bar code and not only some random lines.

Fun fact: The used code is the GTIN-13 for "The Visual Display of
Quantitative Information", Edward R. Tufte.

timhoffm added the Documentation label

Jul 14, 2020

Copy link

Member

jklymak commentedJul 14, 2020

I'd say that in the example? Or do you want it to be an easter egg?

Copy link

MemberAuthor

timhoffm commentedJul 14, 2020

It doesn't really add to the example. So, I'd leave it as an easter egg. But no strong preference.

timhoffm added this to thev3.4.0 milestone

Jul 14, 2020

QuLogic reviewed

Jul 15, 2020

View reviewed changes

examples/images_contours_and_fields/barcode_demo.py OutdatedShow resolvedHide resolved

Rewrite the barcode example

3e790dd

This is a bit particular anyway, but let's make it practical bygenerating a real bar code and not only some random lines.Fun fact: The used code is the GTIN-13 for "The Visual Display ofQuantitative Information", Edward R. Tufte.

timhoffm force-pushed thedoc-barcode branch fromb02fedb to3e790ddCompare

July 15, 2020 00:26

QuLogic approved these changes

Jul 15, 2020

View reviewed changes

jklymak approved these changes

Jul 15, 2020

View reviewed changes

Copy link

Member

jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fine, though not sure about the DPI

examples/images_contours_and_fields/barcode_demo.py

		ax2.set_axis_off()
		ax2.imshow(x.reshape((1, -1)), **barprops)
		pixel_per_bar = 4
		dpi = 100

Copy link

Member

jklymakJul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So not sure this matters, but we save at 200 dpi now, don't we?

Copy link

MemberAuthor

timhoffmJul 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Um, I don't think so. When did that happen?

We now oversample the thumbnails in the gallery (#17734). But that does not affect the images in the examples themselves. Maybe you are mixig this up?