Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

API: resolve unset vmin / vmax in all ScalarMapple based methods#17859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@tacaswell
Copy link
Member

@tacaswelltacaswell commentedJul 8, 2020•
edited by dopplershift
Loading

PR Summary

See analysis in#17703

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@tacaswelltacaswell added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelJul 8, 2020
@tacaswelltacaswell added this to thev3.3.0 milestoneJul 8, 2020
@tacaswelltacaswell requested a review fromtimhoffmJuly 8, 2020 22:00
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Modulo a fix in the API note.

@tacaswelltacaswellforce-pushed thefix_determintic_clim_autoscale branch from6286e1d tobd3fb17CompareJuly 10, 2020 19:58
Copy link
Member

@efiringefiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor typo, otherwise good.

@tacaswelltacaswellforce-pushed thefix_determintic_clim_autoscale branch frombd3fb17 to267f1eaCompareJuly 12, 2020 22:46
@efiringefiring merged commit97785f2 intomatplotlib:masterJul 12, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJul 12, 2020
@tacaswelltacaswell deleted the fix_determintic_clim_autoscale branchJuly 12, 2020 23:06
QuLogic added a commit that referenced this pull requestJul 13, 2020
…859-on-v3.3.xBackport PR#17859 on branch v3.3.x (API: resolve unset vmin / vmax in all ScalarMapple based methods)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@QuLogicQuLogicQuLogic left review comments

@timhoffmtimhoffmtimhoffm approved these changes

@efiringefiringefiring approved these changes

@dstansbydstansbydstansby approved these changes

Assignees

No one assigned

Labels

Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Milestone

v3.3.0

Development

Successfully merging this pull request may close these issues.

QuadMesh.get_clim changed behavior in 3.3.0rc1

5 participants

@tacaswell@efiring@QuLogic@timhoffm@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp