NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Refresh what's new page for 3.3.0#17858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

story645 merged 12 commits intomatplotlib:masterfromQuLogic:doc-330

Jul 15, 2020

Merged

Refresh what's new page for 3.3.0#17858

story645 merged 12 commits intomatplotlib:masterfromQuLogic:doc-330

Jul 15, 2020

Conversation

Copy link

Member

PR Summary

This fixes some minor things (see commit messages), but major thing is the re-ordering.

Generally, this is things-with-a-plot, then things-with-an-example, then some random other stuff, and finally groups of things-with-something-in-common (e.g., all rcParams together).

Now, I'll be adding in plots, but this is maybe large enough to review already.

PR Checklist

[N/A] Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
[N/A] Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

QuLogic added5 commits

July 7, 2020 22:29

DOC: Fix names for GitHub stats pages.

b562b91

Add some duplicate names to mailmap.

1472b39

DOC: Fix some inconsistent heading underlines.

d5eace4

DOC: Don't use cross-references in section titles.

8d82673

This totally messed up the page ToC.

DOC: Re-order 3.3. what's new page.

20ccea8

Generally, this is things-with-a-plot, then things-with-an-example, thensome random other stuff, and finally groups ofthings-with-something-in-common (e.g., all rcParams together).

QuLogic added the Documentation label

Jul 8, 2020

QuLogic added this to thev3.3.0 milestone

Jul 8, 2020

QuLogic mentioned this pull request

Jul 8, 2020

Plot directive may be confused by ..include::#17860

Closed

QuLogic added3 commits

July 8, 2020 19:15

DOC: Shorten a title.

1768605

This prevents overflow of the ToC in the sidebar.

DOC: Add more plots to 3.3 what's new.

fd7eb1d

DOC: Add more entries to 3.3 what's new.

9471870

QuLogic marked this pull request as ready for review

July 9, 2020 22:18

Copy link

MemberAuthor

QuLogic commentedJul 9, 2020

Added more plots, added more entries (like turbo, pie normalize, etc.). You may wish to review the commits separately.

story645 requested changes

Jul 10, 2020

View reviewed changes

Copy link

Member

story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For all my nitpicks, I really do 😍 this what's new.
Big picture, can you group all the RCParam stuff under a subheading, and same /w all the font/text stuff. Maybe also the ticks & labels stuff (the titling, coloring. formatting, etc). the semantic and sharing stuff is all axes creation/management.

doc/users/prev_whats_new/whats_new_3.3.0.rst OutdatedShow resolvedHide resolved

doc/users/prev_whats_new/whats_new_3.3.0.rstShow resolvedHide resolved

doc/users/prev_whats_new/whats_new_3.3.0.rst OutdatedShow resolvedHide resolved

doc/users/prev_whats_new/whats_new_3.3.0.rst

		``canvas.mpl_connect("button_press_event", button_press_handler)``, rather than
		having to write wrapper functions that fill in the (now optional) canvas and
		toolbar parameters.
		Instead, they are implemented using vanilla JavaScript. Please report any

Copy link

Member

story645Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

plain Javascript

Copy link

MemberAuthor

QuLogicJul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Vanilla JS is a'thing'.

Copy link

Member

story645Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yes, that's why I was kinda confused about this terminology here, didn't grok til just now that that's a joke page.

Copy link

MemberAuthor

QuLogic commentedJul 10, 2020

rcParams are already in a subheading; it's just such a low level that our styling doesn't make it super obvious.

DOC: Fix a typo in Axes.pie docstring.

a43d8b3

QuLogic force-pushed thedoc-330 branch fromf0f7421 toeaaf4a8Compare

July 10, 2020 07:13

Copy link

MemberAuthor

QuLogic commentedJul 10, 2020•
edited
Loading

I made some edits except for the things I don't know about noted above. I haven't done any of the requested re-ordering yet. Do you mean group as in move together, or add more headings?

Copy link

Member

story645 commentedJul 10, 2020

Both - group like things together under a subheading, like paths and 3d already have.

Copy link

MemberAuthor

QuLogic commentedJul 10, 2020•
edited
Loading

My new order is now:

Figure and Axes creation / management
- Provisional API for composing semantic axes layouts from text or nested lists
- GridSpec.subplots()
- NewAxes.sharex,Axes.sharey methods
- tight_layout now supports suptitle
- Setting axes box aspect
Colors and colormaps
- Turbo colormap
- colors.BoundaryNorm supportsextend keyword argument
- Text color for legend labels
- Pcolor and Pcolormesh now acceptshading='nearest' and'auto'
Titles, ticks, and labels
- Align labels to Axes edges
- Allow tick formatters to be set with str or function inputs
- Axes.set_title gains ay keyword argument to control auto positioning
- Offset text is now set to the top when usingaxis.tick_top()
Fonts
- Simple syntax to select fonts by absolute path
- Improved font weight detection

followed by these, which have not changed, so I'm not going to copy&paste all the subheadings:

rcParams improvements
3D Axes improvements
Interactive tool improvements
Functions to compute a Path's size
Backend-specific improvements

So now I'm wondering where to put:

NewAxes.axline method
Dates use a modern epoch
Lines now acceptMarkerStyle instances as input
imshow now coerces 3D arrays with depth 1 to 2D
~~Set zorder of contour labels~~ This can go in: Titles, ticks and labels
Better control ofAxes.pie normalization

Copy link

Member

jklymak commentedJul 11, 2020

So now I'm wondering where to put:

I think its OK to have a "other changes" section...

story645 requested changes

Jul 12, 2020

View reviewed changes

Copy link

Member

story645 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Agree w/@jklymak & also most of the rest of these have to do w/ plot types:

New Axes.axline method
imshow now coerces 3D arrays with depth 1 to 2D
Better control of Axes.pie normalization

And d

Dates use a modern epoch
Lines now accept MarkerStyle instances as input

doc/users/prev_whats_new/whats_new_3.3.0.rst OutdatedShow resolvedHide resolved

doc/users/prev_whats_new/whats_new_3.3.0.rstShow resolvedHide resolved

doc/users/prev_whats_new/whats_new_3.3.0.rst Outdated

Comment on lines 453 to 491

		# For the purposes of keeping the documentation build warning-free, and
		# future proof for when the deprecation is made permanent, we pass
		# normalize here explicitly anyway.
		ax[1, 0].pie(x, autopct='%1.2f%%', labels=label(x), normalize=False)
		ax[1, 0].set_title('normalize unspecified\nsum(x) < 1')
		ax[1, 1].pie(x * 10, autopct='%1.2f%%', labels=label(x * 10),
		normalize=True)
		ax[1, 1].set_title('normalize unspecified\nsum(x) > 1')

Copy link

Member

story645Jul 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

why does this need to be in the what's new?

Copy link

MemberAuthor

QuLogicJul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What part specifically?

Copy link

Member

story645Jul 13, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the code and especially this note:

For the purposes of keeping the documentation build warning-free, and
# future proof for when the deprecation is made permanent, we pass
#normalize here explicitly anyway.

Copy link

MemberAuthor

QuLogicJul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry, I'm confused; didn't youask for code?

Copy link

Member

story645Jul 14, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

😦 sorry for the confusion, I did ask for code and the note threw me 'cause I read it as explaining a deprecated feature rather than a new one. Maybe movinng the comment under the code could make it clearer?

Copy link

MemberAuthor

QuLogicJul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, well thisis showing deprecated behaviour as comparison with the new explicit one, but because it's deprecated, I had to use the new explicit one in the code. It's labelled with the old way in the figure though. (Note, this code isn't shown by default.) I could remove it or change the comment description a little?

Copy link

Member

story645Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, if the code/comment isn't shown than it's good enough...

QuLogic added2 commits

July 14, 2020 01:06

DOC: Edit the 3.3 what's new based on review.

e6648a7

DOC: More edits to the 3.3 what's new from review.

2fb42b1

QuLogic force-pushed thedoc-330 branch fromeaaf4a8 to2fb42b1Compare

July 14, 2020 06:16

Copy link

MemberAuthor

QuLogic commentedJul 14, 2020

I pushed the re-ordering and used the following sections for the remaining items:

Plot-type specific changes
- NewAxes.axline method
- imshow now coerces 3D arrays with depth 1 to 2D
- Better control ofAxes.pie normalization
Other changes
- Dates use a modern epoch
- Lines now acceptMarkerStyle instances as input

I'm not super-happy with that first section name, so suggestions welcome.

story645 approved these changes

Jul 14, 2020

View reviewed changes

Copy link

Member

story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for putting up w/ my comments - it's now coherent enough to make me happy.

doc/users/prev_whats_new/whats_new_3.3.0.rst OutdatedShow resolvedHide resolved

DOC: Re-order 3.3 what's new changes.

42ce0c7

QuLogic force-pushed thedoc-330 branch from70d301f to42ce0c7Compare

July 15, 2020 02:13

story645 merged commitb560513 intomatplotlib:master

Jul 15, 2020

meeseeksmachine mentioned this pull request

Jul 15, 2020

Backport PR #17858 on branch v3.3.x (Refresh what's new page for 3.3.0)#17933

Merged

Copy link

Member

story645 commentedJul 15, 2020

@tacaswell said it's docs and therefore can go in w/ one merge (or even a self merge 🤷

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request

Jul 15, 2020

Backport PRmatplotlib#17858: Refresh what's new page for 3.3.0

9109275

tacaswell added a commit that referenced this pull request

Jul 15, 2020

Merge pull request#17933from meeseeksmachine/auto-backport-of-pr-17…

c1c9bc8

…858-on-v3.3.xBackport PR#17858 on branch v3.3.x (Refresh what's new page for 3.3.0)

QuLogic deleted the doc-330 branch

July 15, 2020 18:56

Labels

Documentation

4 participants

Movatterモバイル変換

Uh oh!

Refresh what's new page for 3.3.0#17858

Refresh what's new page for 3.3.0#17858

Uh oh!

Conversation

QuLogic commentedJul 8, 2020

PR Summary

PR Checklist

Uh oh!

QuLogic commentedJul 9, 2020

Uh oh!

story645 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QuLogic commentedJul 10, 2020

Uh oh!

QuLogic commentedJul 10, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

story645 commentedJul 10, 2020

Uh oh!

QuLogic commentedJul 10, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

jklymak commentedJul 11, 2020

Uh oh!

story645 left a comment• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

story645Jul 13, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

story645Jul 14, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

QuLogic commentedJul 14, 2020

Uh oh!

story645 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

story645 commentedJul 15, 2020

Uh oh!

Uh oh!

QuLogic commentedJul 10, 2020•
edited
Loading

QuLogic commentedJul 10, 2020•
edited
Loading

story645 left a comment•
edited
Loading

story645Jul 13, 2020•
edited
Loading

story645Jul 14, 2020•
edited
Loading