Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Changes in the image for test_load_from_url#17776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -713,7 +713,7 @@ def test_minimized_rasterized(): | |||
| def test_load_from_url(): | |||
| path = Path(__file__).parent / "baseline_images/test_image/imshow.png" | |||
| path = Path(__file__).parent / "baseline_images/pngsuite/basn3p04.png" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't understand why we think this image will be permanent either, and it seems a very obscure image to choose. Isn't there something in mpl_data/images that would be more appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This image will remain as it is also used in
| png_path=Path(__file__).parent/"baseline_images/pngsuite/basn3p04.png" |
Secondly, the
basn3p04.png image is not used inimage_comparison tests. So, we don't need to shift it into thempl_baseline_images package in#17557There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
But shouldn’t that be moved as well? It’s going to be pretty confusing to have baseline_images and another package of baseline_images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The primary reason thebasn*.png files exist is as input for the test intest_png so is not in the category of images that will be removed by the GSOC code landing. On the other hand, the file that this used to point is a baseline image that will be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Despite its location, this is actually an "input" for the test suite not an actual baseline image.
PR Summary
Image for the test_load_from_url changed so that it can use the images which are not baseline images. This will be later benificial for the division of mpl into mpl and mpl_baseline_images package as#17557
PR Checklist