Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Mnt drop py36#17662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Mnt drop py36#17662
Uh oh!
There was an error while loading.Please reload this page.
Conversation
32ae2c1 to0d0e88cCompareI can squash this to one commit if we want. |
(prefer this being squashed) |
I left each minimum version change as its own commit but squashed the CI thrashing. |
| TEST_ALL: "no" | ||
| EXTRAREQS: "-r requirements/testing/travis_extra.txt" | ||
| - PYTHON_VERSION: "3.7" | ||
| - PYTHON_VERSION: "3.8" | ||
| CONDA_INSTALL_LOCN: "C:\\Miniconda37-x64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| CONDA_INSTALL_LOCN:"C:\\Miniconda37-x64" | |
| CONDA_INSTALL_LOCN:"C:\\Miniconda38-x64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This doesn't work unless we update the windows image we are using.
| @@ -55,19 +56,15 @@ install: | |||
| # For building, use a new environment | |||
| - conda create -q -n test-environment python=%PYTHON_VERSION% tk | |||
| - activate test-environment | |||
| # pull pywin32 from conda because on py38 there is something wrong with finding | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is that because of wrong conda above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think so, we are still ending up with a py38 env and it should be de-coupled from Python version of the "base" conda enivorment. I think this has to do with Python tightening up its rules about how dlls are discovered. There are a bunch of related issues on the pywin32 issues tracker.
Uh oh!
There was an error while loading.Please reload this page.
a8f1e20 to924e1cfCompareLGTM, but waiting on the API change note. |
This was release in March 2018 and is the first version ofpython-dateutil that does not have deprecation warnings due to thecollections -> collections.abc change in CPython.
This is released in Sept 2018 and is the earliest version to not warndue to the collections -> collections.abc change in CPython.
This is consistent with our policy and NEP29
PR Summary
Drop support for py36
closes#17652
PR Checklist
This should not go in until after we branch v3.3.x off of master and still needs an API change note added (but I want to let the dust settle on the renaming / moving associated with 3.3 before doing that.