Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

More qt fractional DPI fixes#17640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
story645 merged 3 commits intomatplotlib:masterfromQuLogic:more-pyqt5-fixes
Jun 16, 2020

Conversation

QuLogic
Copy link
Member

PR Summary

Followup to#15656.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogicQuLogic added this to thev3.2.2 milestoneJun 15, 2020
@tacaswell
Copy link
Member

image

importmatplotlib.pyplotaspltimportnumpyasnpth=np.linspace(0,2*np.pi,512)fig,ax=plt.subplots()ax.plot(th,np.sin(th))ax.plot(th,np.cos(th))ax.set_title(fig.canvas._dpi_ratio)plt.show()

Each of those was launched with

19:57:24 $with ${...}.swap(QT_SCALE_FACTOR=2.0): ............python/tmp/tester.py& ............

There is no visual difference between this branch and master.

@tacaswelltacaswell mentioned this pull requestJun 16, 2020
@QuLogic
Copy link
MemberAuthor

From what we've seen, I think that should be correct. At least, it seems likesetDevicePixelRatioF andsetDevicePixelRatio do the same thing... Maybe they're there in order to be extra-explicit about types.

@story645story645 merged commit3460e0e intomatplotlib:masterJun 16, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 3460e0e7b40ab61e0626cfeebb3ae9c22f255d16
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #17640: More qt fractional DPI fixes'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-17640-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR#17640 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestJun 16, 2020
Merge pull requestmatplotlib#17640 from QuLogic/more-pyqt5-fixesMore qt fractional DPI fixes
@QuLogicQuLogic deleted the more-pyqt5-fixes branchJune 16, 2020 04:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@story645story645story645 approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@tacaswell@story645

[8]ページ先頭

©2009-2025 Movatter.jp