Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: propagate _is_saving state when changing canvases#17602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
FIX: propagate _is_saving state when changing canvases#17602
Uh oh!
There was an error while loading.Please reload this page.
Conversation
We have logic to draw animated artists if we are rendering due tosavefig (as opposed to rendering to put into a GUI). Not every canvasclass can write every format so we can switch the canvas as save timebased on the requested extension / format. Make sure we set the sateon the canvas we are actually using to save the figure rather than thecanvas that is attached to the figure when we start saving.closesmatplotlib#17599
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm (modulo ci)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm (modulo ci)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm (modulo ci)
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free tosuggest an improvement. |
…anging canvasesMerge pull requestmatplotlib#17602 from tacaswell/fix_mixed_canvas_animation_saveFIX: propagate _is_saving state when changing canvasesConflicts:lib/matplotlib/backend_bases.py - other nearby changes, only backport the context manager related changeslib/matplotlib/tests/test_figure.py - did not backport the other tests that are currently only on master branch.
…-v3.2.xBackport PR#17602: FIX: propagate _is_saving state when changing can…
PR Summary
We have logic to draw animated artists if we are rendering due to
savefig (as opposed to rendering to put into a GUI). Not every canvas
class can write every format so we can switch the canvas as save time
based on the requested extension / format. Make sure we set the sate
on the canvas we are actually using to save the figure rather than the
canvas that is attached to the figure when we start saving.
closes#17599
PR Checklist