NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Support url on QuadMesh in svg#17514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

QuLogic wants to merge5 commits intomatplotlib:main

base:main

Choose a base branch

fromQuLogic:svg-url-quadmesh

Draft

Support url on QuadMesh in svg#17514

QuLogic wants to merge5 commits intomatplotlib:mainfromQuLogic:svg-url-quadmesh

Conversation

Copy link

Member

QuLogic commentedMay 26, 2020

PR Summary

This is just a quick rebase of the two commits from#17338. I have not addressed the comments yet, so this is just a PR so I don't forget about it.

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

khyoxand others added5 commits

May 26, 2020 18:20

Override set_url() in class Tick

0f29996

In the class Tick, the url attribute is not passed to any of the objectsthat are to be drawn. Suggested solution is to override the set_url()method in Tick to transfer the url attribute content to the tick labels,that are to be drawn.

Add test for urls on ticks in svg.

4984505

Ensure URLs are stored for plain lines in SVG.

eecad37

Fixesmatplotlib#17336.

Support URLs on QuadMesh in SVGs.

82a91c5

Fixesmatplotlib#12392.

Fix draw_quad_mesh for backends without urls support.

51ed286

QuLogic added the backend: svg label

May 26, 2020

QuLogic added this to thev3.4.0 milestone

May 26, 2020

QuLogic modified the milestones:v3.4.0,v3.5.0

Jan 21, 2021

QuLogic modified the milestones:v3.5.0,v3.6.0

Aug 18, 2021

timhoffm modified the milestones:v3.6.0,unassigned

Apr 30, 2022

story645 modified the milestones:unassigned,needs sorting

Oct 6, 2022

github-actionsbot added the status: needs rebase label

Oct 18, 2022

Copy link

github-actionsbot commentedAug 4, 2023

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.