Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix dicts unpacking for.plot#17506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 5 commits intomatplotlib:masterfromstory645:fix-dicts
May 25, 2020
Merged

Conversation

story645
Copy link
Member

@story645story645 commentedMay 25, 2020
edited
Loading

PR Summary

d = {4:1, 6:2}plt.plot(d.keys(), d.values())

is supposed to work & then stopped working because of changes to how.plot processes the data kwarg (#10928). This PR takes the dead simple approach of running the args to.plot through sanitize_sequence since it's a pass through function, but there's probably a better way.

Also added a bunch of tests to hopefully catch this. I think this is release critical since it worked in 3.0 and broke in 3.1, but on the other hand I only noticed this 'cause I wanted to update some docs (that actually should have been fine even w/o the fix 🙃)

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@story645story645 changed the titleFix dictsFix dicts unpacking for.plotMay 25, 2020
@story645story645 added this to thev3.3.0 milestoneMay 25, 2020
@story645story645 added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelMay 25, 2020
@story645story645 linked an issueMay 25, 2020 that may beclosed by this pull request
@tacaswelltacaswell merged commitfcb0a41 intomatplotlib:masterMay 25, 2020
@story645story645 deleted the fix-dicts branchOctober 6, 2023 16:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

dict unpacking broken for.plot in 3.2
3 participants
@story645@timhoffm@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp