Restores support of the color-favoring special case documented in the docstring and warning. Independent of if we think this was a good design initially etc we pretty clearly document that this is the expected behavior and it was the behavior in 3.1 so it should be restored.

Also tweaked the docstring to direct users to thecolor kwarg which does not have the "should we colormap?" ambiguity.

Closes#17423

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
Documentation is sphinx and numpydoc compliant

tacaswell added2 commits

May 23, 2020 13:00

FIX: fix support for single color 2D array as c to mean single color

d84f4a7

Closesmatplotlib#17423

DOC: tweak wording about c input to scatter

1a56e12

Encourage user to use the *color* keyword in the case where they haveonly one color.

tacaswell added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label

May 23, 2020

tacaswell added this to thev3.2.2 milestone

May 23, 2020

tacaswell mentioned this pull request

May 23, 2020

Scatter produce multiple colors for a single RGB/RGBA input#17423

Closed

jklymak reviewed

May 23, 2020

View reviewed changes

lib/matplotlib/axes/_axes.py

		@@ -4281,19 +4281,26 @@ def invalid_shape_exception(csize, xsize):
		except ValueError:
		pass # Failed to convert to float array; must be color specs.
		else:
		# handle the documented special case of a 2D array with 1
		# row which as RGB(A) to broadcast.
		if c.shape == (1, 4) or c.shape == (1, 3):

Copy link

Member

jklymakMay 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK, but do we want a 2-d array or a list of arrays as the special case?

Copy link

Member

efiringMay 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't understand. Would you elaborate, please? Why would there be a distinction here?

Copy link

Member

jklymakMay 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The particular value for c is something like:c = [[0.1, 0.1, 0.4]]?

Copy link

MemberAuthor

tacaswellMay 23, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We doc = np.asanyarray(c, dtype=float) a few lines above to normalizec. I do not think we want to get into the business of distinguishing between[[a, b, c]],[np.array([a, b, c])], andnp.array([[a, b, c]]) as input.

Copy link

Member

jklymakMay 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK, but an unsqueezed 1x3 ndarray is a perfectly valid thing to pass forc if I have 3 data points. So how can we tell them apart?

Copy link

Member

efiringMay 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Before it is squeezed, the dimensions are checked so that a 1x3 or 1x4 can be interpreted as a color. The (3,) or (4,) 1-d cases, when the size matches the number of points, is interpreted as a sequence of values to be mapped. This is the documented way the ambiguity is resolved, based on a decision made long ago. I just fouled it up in the last change I made to the code. Thomas is cleaning up my mess.

efiring approved these changes

May 23, 2020

View reviewed changes

jklymak approved these changes

May 23, 2020

View reviewed changes

efiring merged commit346f6f7 intomatplotlib:master

May 23, 2020

Copy link

lumberbot-appbot commentedMay 23, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

Checkout backport branch and update it.

$ git checkout v3.2.x$ git pull

Cherry pick the first parent branch of the this PR on top of the older branch:

$ git cherry-pick -m1 346f6f77dd2ce712c1ba35fcca988630e835cb69

You will likely have some merge/cherry-pick conflict here, fix them and commit:

$ git commit -am 'Backport PR #17499: Fix scatter singlecolor'

Push to a named branch :

git push YOURFORK v3.2.x:auto-backport-of-pr-17499-on-v3.2.x

Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR#17499 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

lumberbot-appbot added the status: needs manual backport label

May 23, 2020

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request

May 23, 2020

Backport PRmatplotlib#17499: Fix scatter singlecolor

871bbfc

Merge pull requestmatplotlib#17499 from tacaswell/fix_scatter_singlecolorFix scatter singlecolorConflicts:lib/matplotlib/axes/_axes.py         - implicitly backport some extra docstring changes

tacaswell deleted the fix_scatter_singlecolor branch

May 23, 2020 21:43

tacaswell mentioned this pull request

May 23, 2020

Backport PR #17499: Fix scatter singlecolor#17501

Merged

6 tasks

tacaswell added a commit that referenced this pull request

May 23, 2020

Merge pull request#17501from tacaswell/auto-backport-of-pr-17499-on…

460805d

…-v3.2.xBackport PR#17499: Fix scatter singlecolor

QuLogic removed the status: needs manual backport label

May 25, 2020

QuLogic mentioned this pull request

Jul 21, 2020

Plotting three points using scatter results in wrong color - 1.4.3#5377

Closed

Labels

Release critical

For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

4 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix scatter singlecolor#17499

Fix scatter singlecolor#17499

Uh oh!

Conversation

tacaswell commentedMay 23, 2020•
edited
Loading

Uh oh!

PR Summary

PR Checklist

Uh oh!

jklymakMay 23, 2020

Choose a reason for hiding this comment

Uh oh!

efiringMay 23, 2020

Choose a reason for hiding this comment

Uh oh!

jklymakMay 23, 2020

Choose a reason for hiding this comment

Uh oh!

tacaswellMay 23, 2020•
edited
Loading

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jklymakMay 23, 2020

Choose a reason for hiding this comment

Uh oh!

efiringMay 23, 2020

Choose a reason for hiding this comment

Uh oh!

lumberbot-appbot commentedMay 23, 2020

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

Fix scatter singlecolor#17499

Fix scatter singlecolor#17499

Uh oh!

Conversation

tacaswell commentedMay 23, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

jklymakMay 23, 2020

Choose a reason for hiding this comment

Uh oh!

efiringMay 23, 2020

Choose a reason for hiding this comment

Uh oh!

jklymakMay 23, 2020

Choose a reason for hiding this comment

Uh oh!

tacaswellMay 23, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jklymakMay 23, 2020

Choose a reason for hiding this comment

Uh oh!

efiringMay 23, 2020

Choose a reason for hiding this comment

Uh oh!

lumberbot-appbot commentedMay 23, 2020

Uh oh!

Uh oh!

tacaswell commentedMay 23, 2020•
edited
Loading

tacaswellMay 23, 2020•
edited
Loading