Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: add guardrails for too big tk figures#17470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 2 commits intomatplotlib:masterfromtacaswell:fix_too-big-tk
Jun 3, 2020

Conversation

tacaswell
Copy link
Member

PR Summary

Depending on the version of xserver creating a too big tk window
either corrupts xorg (!) or causes the process to exit. This adds a
guard rail that will convert this into a python exception instead.

closes#17460

PR Checklist

  • Has Pytest style unit tests
  • [k] Code isFlake 8 compliant

Not sure if it is worth adding a test for this as it is such an out-there condition.

@tacaswelltacaswell added this to thev3.2.2 milestoneMay 21, 2020
@jklymak
Copy link
Member

Could we just have a warning for > 1000 inches? Ie your figure is gigantic, and the backend may have difficulty?

@tacaswell
Copy link
MemberAuthor

In some combinations of tk and xserver we need to actually prevent the call to tk so we need more than a warning. I'm hesitant to put a non externally motivated hard maximum size (8MB is big enough for anyone!).

@jklymak
Copy link
Member

That’s why I suggested a warning. In this case the user was accidentally setting the fig size to something crazy, and a warning would have helped debug the problem. I don’t think we can or should add different guard rails for every system and backend combination

@tacaswell
Copy link
MemberAuthor

Can we do the warnings in a follow on?

Depending on the version of xserver creating a too big tk windoweither corrupts xorg (!) or causes the process to exit.  This adds aguard rail that will convert this into a python exception instead.closesmatplotlib#17460
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@QuLogicQuLogic merged commit89fa0e4 intomatplotlib:masterJun 3, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJun 3, 2020
QuLogic added a commit that referenced this pull requestJun 4, 2020
…470-on-v3.2.xBackport PR#17470 on branch v3.2.x (FIX: add guardrails for too big tk figures)
@tacaswelltacaswell deleted the fix_too-big-tk branchMay 6, 2021 23:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer left review comments

@timhoffmtimhoffmtimhoffm left review comments

@QuLogicQuLogicQuLogic approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

set_size_inches with a width over 14090 crashes Xorg
5 participants
@tacaswell@jklymak@QuLogic@anntzer@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp