Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

constrained_layout rewrite....#17437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
jklymak wants to merge36 commits intomatplotlib:masterfromjklymak:new-layout

Conversation

jklymak
Copy link
Member

@jklymakjklymak commentedMay 17, 2020
edited
Loading

PR Summary

Just a draft for now, but this is meant to be substantially simpler than the currentconstrained_layout and more robust. Some of the flakiness should be gone. Colorbars are better located, and respect their anchors now.

This version includes the idea offigure.sub_panels, but that could be (reluctantly) taken out if its deemed not useful. It does get you nice things like:

SubpanelExample

It wold have been nice to do them separately but it was pretty hard to make sure everything works for the nesting....

Most of the constrained_layout baseline images have changed, but thats because colorbar sizing has changed (for the better), and small changes to how padding is handled. I don't feel any of the choices made here make any of the images worse, and I don't think its worth trying to make them the same. I could be convinced to change a lot of these to assertions on the position of the axes, but its then a challenge to see what goes wrong if they break.

  • check colorbar aspect
  • tests for subpanel...
  • modify tutorial and docstring
  • add tutorial forsubpanel.
    • modify transform tutorial

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymakjklymak added the topic: geometry managerLayoutEngine, Constrained layout, Tight layout labelMay 17, 2020
@jklymakjklymak added this to thev3.4.0 milestoneMay 17, 2020
@jklymak
Copy link
MemberAuthor

jklymak commentedMay 21, 2020
edited
Loading

Rebasing for this is going to be a big PITA because I have so much re-organization infigure.py. That re-org is because I've re-introducedsubpanel here. Maybe we should have some comment on whether that has any chance of going in before I tear my hair out trying to keep it all synced. See the new examplesubpanels.py for how this feature works.

https://37230-1385122-gh.circle-artifacts.com/0/doc/build/html/gallery/subplots_axes_and_figures/subpanels.html#sphx-glr-gallery-subplots-axes-and-figures-subpanels-py

@jklymakjklymak added the status: needs comment/discussionneeds consensus on next step labelMay 21, 2020
@jklymak
Copy link
MemberAuthor

Closing this for now in lieu of#17494 which doesn't have any of the changes to figure and subpanel.

@jklymakjklymak mentioned this pull requestMay 29, 2020
6 tasks
@tacaswelltacaswell modified the milestones:v3.4.0,unassignedJun 15, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: needs comment/discussionneeds consensus on next steptopic: geometry managerLayoutEngine, Constrained layout, Tight layout
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jklymak@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp