Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Unstale viewlims before draw()ing polar axes.#17422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:polarunstale
May 16, 2020

Conversation

anntzer
Copy link
Contributor

PR Summary

Closes#17418 (likely a regression in 3.2).

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: polar labelsMay 15, 2020
@anntzeranntzer added this to thev3.2.2 milestoneMay 15, 2020
@QuLogic
Copy link
Member

Confirmed regression fromv3.1.x.

@QuLogic
Copy link
Member

Also, that last Azure job was cancelled, but not reporting to GitHub, so I can't restart it.

@tacaswell
Copy link
Member

Restarted the job (side note, I don't understand the ACL model between GH and Azure).

I am not sure I understand why this change fixes things, but 👍 .

Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Anyone can merge on CI green.

@QuLogic
Copy link
Member

Since you were wondering, this came from#13593, which made autoscaling lazy. The call to_unstale_viewLim is inAxesBase.draw, but obviously, that was missed to be added inPolarAxes.

@QuLogicQuLogic merged commite70c6f8 intomatplotlib:masterMay 16, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 e70c6f83be30076802398c6cf09b497077b4d1a8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #17422: Unstale viewlims before draw()ing polar axes.'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-17422-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR#17422 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

@tacaswell
Copy link
Member

The call to _unstale_viewLim is in AxesBase.draw

Ah, that makes sense.

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestMay 17, 2020
Unstale viewlims before draw()ing polar axes.Conflicts:lib/matplotlib/projections/polar.py          - conflicts from nearyby changes to signature of drawlib/matplotlib/tests/test_polar.py          - tests are still in test_axes.py on v3.2.x
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestMay 17, 2020
… axes.Merge pull requestmatplotlib#17422 from anntzer/polarunstaleUnstale viewlims before draw()ing polar axes.Conflicts:lib/matplotlib/projections/polar.py          - conflicts from nearyby changes to signature of drawlib/matplotlib/tests/test_polar.py          - tests are still in test_axes.py on v3.2.x
dstansby added a commit that referenced this pull requestMay 18, 2020
…-v3.2.xBackport PR#17422: Unstale viewlims before draw()ing polar axes.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.topic: polar
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

Issue rendering polar plot (agg backend?) with rorigin set
3 participants
@anntzer@QuLogic@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp