Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Revert "DOC: drop the experimental tag constrained_layout and tight_layout"#17413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
QuLogic approved these changesMay 14, 2020
Fair enough, Thanks for all of your work on this@jklymak ! |
MemberAuthor
jklymak commentedMay 15, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@mwaskom I should point this out to you as well because you expressed an interest. I don’t think anything fundamental will change but there may be a few slight changes. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
DocumentationRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: geometry managerLayoutEngine, Constrained layout, Tight layout
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK, I've been working on constrained layout a lot lately, and havegreatly simplified it, to the point where I'd like to keep the experimental tag for 3.3, in anticipation of some minor changes for 3.4. I don't anticipate that any of the API will change, and the features will be the same, however, a few of the layout details may change.
Sorry for the churn, but the new implementation is far less confusing (I think).
Reverts#17094