Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
BUGFIX: scatter should draw ',' as a single pixel#17367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it. |
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Attempt tofix#11460.
Instead of adding a special case to
PathCollection
, which (IMO, and I am happy to be told I'm wrong about this) has no business knowing that the path it's drawing came from a MarkerStyle at all, let alone that it came from the weird, special-case marker','
, I added a kwarg to_CollectionWithSizes
that allows one to specify that the self-same sizes should actually just be ignored. With this in place,Axes.scatter
(whichdoes know that we are usingMarkerStyle
) can pass the appropriatePath
toPathCollection
(of width one) and ask the PathCollection to ignore the scaling information, which is what that particular marker issupposed to do, I think.WIP because I can't seem to figure out one last little issue, where what appear to be identical inputs are being sent to Agg's
draw_marker
and producing two different results (off-by-one pixel).Test Cases
Output
(Screenshots from GIMP to make it more clear exactly what the error is)
plot
case (correctly one pixel):scatter
case currently in master (many pixels...):scatter
case in current PR (almost correct):PR Checklist