Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Backport eps work#17257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 4 commits intomatplotlib:v3.2.xfromtacaswell:backport_eps_work
Apr 28, 2020
Merged

Conversation

tacaswell
Copy link
Member

PR Summary

This is the stack of PRs that I had to backport to make them all apply relatively cleanly. All are arguably bug-fixes. The 2nd (#16913) and 4th (#17255 ) are the likely the critical ones.

I have verified that the example from#17253 works. Probably should add that as a test...

(re)closes#17253.

jklymakand others added4 commitsApril 28, 2020 15:06
Define \mathdefault as a noop in the usetex preamble.Conflicts:   lib/matplotlib/ticker.py      change of a near-by conditional from np.abs -> abs caused      conflict
Fix use of psfrags in ps backend + usetex.Conflicts:lib/matplotlib/backends/backend_ps.py          - near by change of rcParams -> mpl.rcParamslib/matplotlib/texmanager.py          - do not implicitly backport rcParam deprecations
Fix baseline alignment when using usetex.Conflicts:lib/matplotlib/tests/test_usetex.py          - import np and formatting issues on decorator
@tacaswelltacaswell added this to thev3.2.2 milestoneApr 28, 2020
@tacaswelltacaswell requested a review fromanntzerApril 28, 2020 19:29
Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

postci.

@anntzer
Copy link
Contributor

anntzer commentedApr 28, 2020
edited
Loading

The reason I didn't write a test is that ghostscript actually doesn't error when rendering the "bad" ps files, just gives a blank page, and as usual I didn't want to add a baseline image. I guess one could use the usual trick of rendering the thing, "manually" (i.e. by calling ghostscript in the test) converting to png, and checking that the page isn't all white...

@tacaswell
Copy link
MemberAuthor

I went through a very similar thought process. Would it be reliable to render the example@QuLogic came up with verify that the mediabox is correct?

@anntzer
Copy link
Contributor

I guess "yes", but it's really a super indirect test, it wouldn't be obvious at all why these values are the correct ones.

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems reasonable.

@QuLogicQuLogic merged commit2f4a3e3 intomatplotlib:v3.2.xApr 28, 2020
@tacaswelltacaswell deleted the backport_eps_work branchMay 6, 2021 23:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@anntzeranntzeranntzer approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

4 participants
@tacaswell@anntzer@QuLogic@jklymak

[8]ページ先頭

©2009-2025 Movatter.jp