NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Reuse inset_axes locator machinery for secondary_axes.#17249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

anntzer wants to merge1 commit intomatplotlib:masterfromanntzer:secondary

Closed

Reuse inset_axes locator machinery for secondary_axes.#17249

anntzer wants to merge1 commit intomatplotlib:masterfromanntzer:secondary

Conversation

Copy link

Contributor

anntzer commentedApr 27, 2020

_make_secondary_locator is just a special-case of _make_inset_locator,
so just use the latter.

Also change _make_inset_locator to use transform subtraction instead of
.inverted(), as it is typically more precise (as discussed in#17206).

PR Summary

PR Checklist

Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Reuse inset_axes locator machinery for secondary_axes.

bfca92e

_make_secondary_locator is just a special-case of _make_inset_locator,so just use the latter.Also change _make_inset_locator to use transform subtraction instead of`.inverted()`, as it is typically more precise.

anntzer added the Maintenance label

Apr 27, 2020