Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Improve error handling in _parse_scatter_color_args#17245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
33ee858 toa397322Comparea397322 to0c44be6CompareIs that the right issue number? |
Ups, fixed the number. |
QuLogic approved these changesApr 28, 2020
jklymak approved these changesApr 29, 2020
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Fixes#17243
The problem was that
mcolors.to_rgba_array(c)can raise two categories of ValueErrors. One are generic array conversion-related errors, the other is our ownValueError('RGBA values should be within 0-1 range'). Only the former should be catched and rewritten. Our ownValueErrorshould directly surface.I chose the simple approach of just checking the error message. One could alternatively introduce an own Exception subtype. But we're not really doing that in other places and
ValueErrorseems exactly right for out-of-bounds numbers.