Has Pytest style unit tests
Code isFlake 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer added GUI: tk topic: animation labels

Apr 16, 2020

anntzer added this to thev3.3.0 milestone

Apr 16, 2020

anntzer force-pushed thetimerintinterval branch from98b19f0 to4eb6649Compare

April 16, 2020 21:36

timhoffm reviewed

Apr 16, 2020

View reviewed changes

lib/matplotlib/backend_bases.pyShow resolvedHide resolved

anntzer force-pushed thetimerintinterval branch from4eb6649 to5e3498fCompare

April 16, 2020 22:20

QuLogic approved these changes

Apr 16, 2020

View reviewed changes

timhoffm approved these changes

Apr 16, 2020

View reviewed changes

Copy link

Member

QuLogic commentedApr 17, 2020

This appears to be broken on some backends.

anntzer force-pushed thetimerintinterval branch from5e3498f to8ffaf34Compare

April 17, 2020 08:28

Copy link

ContributorAuthor

anntzer commentedApr 17, 2020

Hopefully fixed, and caught a bug on timerwx at the same time (see changelog).

timhoffm added the status: needs revision label

Apr 17, 2020

Correctly go through property setter when init'ing Timer interval.

96690e1

The setter casts the interval to an int, which is required at least bythe tk backend.This caught a bug in the wx timer, where just setting the interval wouldstart the timer.  Fixed that.

anntzer removed the status: needs revision label

Apr 17, 2020

anntzer force-pushed thetimerintinterval branch from55b7d30 to96690e1Compare

April 17, 2020 20:51