Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix most instances of D404 ("docstring should not start with 'this'").#17148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromanntzer:d404
Apr 15, 2020

Conversation

anntzer
Copy link
Contributor

... and associated rewordings.

(xref#17145 (comment)).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer changed the titleFix most instances of D404 ("docstring should not start with 'this').Fix most instances of D404 ("docstring should not start with 'this'").Apr 15, 2020
This method can only be used after an initial draw which
caches the renderer. It is used to efficiently update Axes
data (axis ticks, labels, etc are not updated).
It is used to efficiently redraw Axes data (axis ticks, labels, etc.,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
ItisusedtoefficientlyredrawAxesdata (axisticks,labels,etc.,
EfficientlyredrawAxesdata (axisticks,labels,etc.,

@@ -1026,9 +1026,9 @@ def Destroy(self, *args, **kwargs):

class FigureManagerWx(FigureManagerBase):
"""
This class contains the FigureCanvas and GUI frame
A class contains the FigureCanvas and GUI frame.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
AclasscontainstheFigureCanvasandGUIframe.
Container/controllerfortheFigureCanvasandtheGUIframe.

This function actually creates the wind barbs. *u* and *v*
are components of the vector in the *x* and *y* directions,
respectively.
Actually creates the wind barbs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Actuallycreatesthewindbarbs.
Createwindbarbs.

@@ -1,5 +1,5 @@
"""
This moduleis to support the *bbox_inches* parameter in `.Figure.savefig`.
Support modulefor the *bbox_inches* parameter in `.Figure.savefig`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Supportmoduleforthe*bbox_inches*parameterin`.Figure.savefig`.
Helpermoduleforthe*bbox_inches*parameterin`.Figure.savefig`.

I have the impression that "helper module" is more common than "support module", but not sure.

Comment on lines 214 to 215
Thebase class of all bounding boxes,which provides read-only access
to its data. A mutable bounding box is provided by the `Bbox` class.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
Thebaseclassofallboundingboxes,whichprovidesread-onlyaccess
toitsdata.Amutableboundingboxisprovidedbythe`Bbox`class.
Thebaseclassofallboundingboxes.
Thisboxisimmutable.See`Bbox`foramutableboundingbox.

@anntzer
Copy link
ContributorAuthor

thanks, all handled.

@timhoffmtimhoffm merged commit3b111ac intomatplotlib:masterApr 15, 2020
@anntzeranntzer deleted the d404 branchApril 15, 2020 14:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

2 participants
@anntzer@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp