So it doesn't post here because the token is for the PR repo and not this repo. I'm not sure if that will fix itself once merged.

Considering also addingcppcheck and eslint, but there's a bug in reviewdog preventing the latter. We could also add some things likemisspell orlanguagetool, but I'm not sure if we want to (hard to say for technical things how useful spell-check is.)

@tacaswell ran a test PR for me here:QuLogic#5 Unfortunately, PRs don't get writable tokens for Checks API, so it won't post its separate Check with the annotation like in my test.

That's a bit disappointing, but at least it's not hidden inside Travis checks now. There are a couple of other token/review options that I will check, but if none is better, I'll rename some of the stages to make it more obvious what to look at on error.

Ah wait, I'm totally blind. The fallback annotationsdo show up; they just aren't on the sub-job, but the top-level "Linting" section.

Updated for#17145, and updated docs due to#17040.

If you're looking for spellchecking in code, you can also look at codespell.

I ran codespell and opened#17184, though there are still several false positives that might impede enabling it on PRs immediately.

Is there still something to do on this PR or can it be merged?

It can be merged; that's why it's no longer draft.