Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

BUGFIX: conditional for add_axes arg deprecation#17142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

brunobeltran
Copy link
Contributor

PR Summary

Fixes#17114.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@timhoffm
Copy link
Member

Flake8:
./lib/matplotlib/figure.py:1207:30: E713 test for membership should be 'not in'

@brunobeltran
Copy link
ContributorAuthor

Thanks@timhoffm, hopefully CI passes this time.

Pretty embarrassing that I managed to failflake8 with like a four-word change, didn't even bother running it the first time locally 😅

Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

anyone can merge postci

brunobeltran reacted with thumbs up emoji
@anntzeranntzer merged commit291d5d7 intomatplotlib:masterApr 15, 2020
@QuLogicQuLogic added this to thev3.3.0 milestoneApr 15, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

add_axes shows deprecation warning when called with onlykwargs
4 participants
@brunobeltran@timhoffm@anntzer@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp