Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: drop the experimental tag constrained_layout and tight_layout#17094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

jklymak
Copy link
Member

PR Summary

constrained_layout was marked experimental. Its been around for a couple of years with no indication that the API will change, and no complete show-stoppers so I propose to drop the experimental tag.

Interestingly, as I grepped for "experimental"tight_layout was deemed experimental as well.

Both tutorials had useful information in the same clause as the experimental designation, so I tried to maintain that info in the rewrite.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymakjklymakforce-pushed thedoc-drop-experimental-constrained branch from2f4e728 to7c8b384CompareApril 10, 2020 15:30
@jklymakjklymak added Documentation topic: geometry managerLayoutEngine, Constrained layout, Tight layout labelsApr 10, 2020
@jklymak
Copy link
MemberAuthor

I guess this should get two approvals because it is dropping an "experimental" tag.

@tacaswelltacaswell added this to thev3.3.0 milestoneApr 10, 2020
@timhoffm
Copy link
Member

IMHO we should mention the transition to a stable feature in a what's new or API change entry.

@jklymak
Copy link
MemberAuthor

Sure, what's-new entry added.

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If@jklymak thinks it's not experimental, that's good enough for me.

@QuLogicQuLogic merged commiteb0917b intomatplotlib:masterApr 13, 2020
@jklymakjklymak deleted the doc-drop-experimental-constrained branchApril 15, 2020 15:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Documentationtopic: geometry managerLayoutEngine, Constrained layout, Tight layout
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

4 participants
@jklymak@timhoffm@tacaswell@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp