Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix SyntaxErrors when running setup in old Python#17076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 2 commits intomatplotlib:masterfromQuLogic:old-setup
Apr 9, 2020

Conversation

QuLogic
Copy link
Member

PR Summary

We just got another report about this, so that tells me we're not ready to remove the Python version check insetup.py. I know the suggestion in#16837 is to move the jQuery stuff, but soon I'll be removing it entirely, so I didn't bother.

Fixes#17075.

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

We cannot yet rely on pip to be new enough to recognize outpython_requires, and we get several reports of broken syntax on olderPython.
@QuLogicQuLogic added the Build labelApr 8, 2020
@QuLogicQuLogic added this to thev3.2.2 milestoneApr 8, 2020
@timhoffmtimhoffm merged commit2c62f06 intomatplotlib:masterApr 9, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 2c62f063e8bf1a1109cd9e78c472ac026c73b074
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #17076: Fix SyntaxErrors when running setup in old Python'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-17076-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR#17076 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

@QuLogicQuLogic deleted the old-setup branchApril 9, 2020 07:54
timhoffm added a commit to timhoffm/matplotlib that referenced this pull requestApr 18, 2020
dstansby added a commit that referenced this pull requestApr 18, 2020
…v3.2.xBackport PR#17076: Fix SyntaxErrors when running setup in old Python
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

Installation error downloading jquery on python3 on Ubuntu
3 participants
@QuLogic@tacaswell@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp