Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Simplify subgridspec example/tutorial.#17057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromanntzer:subgrid
Apr 7, 2020

Conversation

anntzer
Copy link
Contributor

  • Use add_gridspec to construct the gridspec and subgridspec to
    construct the subgridspec, saving an import.
  • Use nested loops rather than itertools.product, which is nice but
    not really the point of the tutorial.
  • Index gridspecs with two indices rather than a single flat index,
    again matching "standard" use.
  • Set spine visiibility to the right value directly, rather than first
    toggling them all off and then a few on again.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

- Use add_gridspec to construct the gridspec and subgridspec to  construct the subgridspec, saving an import.- Use nested loops rather than itertools.product, which is nice but  not really the point of the tutorial.- Index gridspecs with two indices rather than a single flat index,  again matching "standard" use.- Set spine visiibility to the right value directly, rather than first  toggling them all off and then a few on again.
@anntzeranntzer added this to thev3.3.0 milestoneApr 7, 2020
@timhoffmtimhoffm merged commitc42d198 intomatplotlib:masterApr 7, 2020
@anntzeranntzer deleted the subgrid branchApril 7, 2020 15:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

2 participants
@anntzer@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp