Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Correctly disable more drawing methods in tight_bboxing renderer.#16980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:draw_disabled
Mar 31, 2020

Conversation

anntzer
Copy link
Contributor

These methods also try to write to the output file.

Closes#16978.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. backend: svg labelsMar 31, 2020
@anntzeranntzer added this to thev3.3.0 milestoneMar 31, 2020
@tacaswell
Copy link
Member

Can you add a test for thesvgz case? I think a trivial figure will hit this?

Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

would prefer a test to make sure we don't lose this code in the future.

These methods also try to write to the output file.
@anntzer
Copy link
ContributorAuthor

sure, test added.

@QuLogicQuLogic merged commitc30129b intomatplotlib:masterMar 31, 2020
@QuLogic
Copy link
Member

Wait, did you want this backported? Or a different fix for 3.2.2?

@anntzeranntzer deleted the draw_disabled branchMarch 31, 2020 20:34
@anntzer
Copy link
ContributorAuthor

anntzer commentedMar 31, 2020•
edited
Loading

Oops, I guess this should have been milestone to 3.2.2, sorry.
Tagged, but dunno if meeseeksdev can handle that.

@QuLogic
Copy link
Member

@meeseeksdev backport to v3.2.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 31, 2020
@QuLogicQuLogic modified the milestones:v3.3.0,v3.2.2Mar 31, 2020
QuLogic added a commit that referenced this pull requestApr 1, 2020
…980-on-v3.2.xBackport PR#16980 on branch v3.2.x (Correctly disable more drawing methods in tight_bboxing renderer.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
backend: svgRelease criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

savefig("myplot.svgz", bbox_inches="tight") fails
3 participants
@anntzer@tacaswell@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp