Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

MAINT: Replace uses of tostring with tobytes#16958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromeric-wieser:remove-tostring
Mar 30, 2020

Conversation

eric-wieser
Copy link
Contributor

tostring() is the pre-numpy-1.9 name, and is not a good name in python3 where the return type isnotstr.

xrefnumpy/numpy#15867

tostring() is the pre-numpy-1.9 name, and is not a good name in python3 where the return type is _not_ `str`.
Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

hopefully ci passes :)

@timhoffmtimhoffm added this to thev3.2.2 milestoneMar 30, 2020
@timhoffmtimhoffm merged commit2e8c0c7 intomatplotlib:masterMar 30, 2020
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 2e8c0c75f98d9f77cc8e17801ac77151083d1dc0
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16958: MAINT: Replace uses of tostring with tobytes'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-16958-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR#16958 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free tosuggest an improvement.

@eric-wieser
Copy link
ContributorAuthor

Probably easier to manually backport withs/tostring\(/tobytes\(/g

dstansby added a commit that referenced this pull requestApr 18, 2020
Backport PR#16958: MAINT: Replace uses of tostring with tobytes
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

3 participants
@eric-wieser@anntzer@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp