Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix missing parameter initialization in Axes.specgram()#16947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 5 commits intomatplotlib:masterfromStefan-Mitic:issue/9100
Apr 2, 2020

Conversation

Stefan-Mitic
Copy link
Contributor

@Stefan-MiticStefan-Mitic commentedMar 28, 2020•
edited by timhoffm
Loading

PR Summary

Added check to set Fs in _axes.specgram() to be Fs = freq[-1] * 2.
Added a test to test_axes.py to check if Fs is None that it won't throw an error.

Closes#9100

PR Checklist

  • Has Pytest style unit tests
  • Code isFlake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

modulo fixing the style issue.

@tacaswell
Copy link
Member

Thanks@Stefan-Mitic ! Other than the issue with the style, this looks good to me!

@tacaswelltacaswell added this to thev3.3.0 milestoneMar 30, 2020
@timhoffmtimhoffm changed the titlesolution: docstring of parameter Fs of matplotlib.pyplot.specgram() inconsistent with default value #9100Fix missing parameter initialization in Axes.specgram()Mar 31, 2020
@timhoffmtimhoffm merged commit97d9cd1 intomatplotlib:masterApr 2, 2020
@timhoffm
Copy link
Member

Thanks, and congratulations on your first contribution to Matplotlib. We hope to see you back some time.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

Parameter Fs initialization missing in Axes.specgram()
3 participants
@Stefan-Mitic@tacaswell@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp